Bug 541964 – [Win32] Setting modal hint to current value might confuse

2008-07-07  Cody Russell  <bratsche@gnome.org>

        Bug 541964 – [Win32] Setting modal hint to current value might confuse the stack

        * gdk/win32/gdkwindow-win32.c: Check if	the value is the same as the
        existing modal hint value before setting it.

svn path=/trunk/; revision=20809

diff --git a/ChangeLog b/ChangeLog
index d5716f0d8241f83bd4b0bb30ac75510de18eda67..f7f855bb623fa9a24f3917ee8c99c5fc898f4af3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-07-07  Cody Russell  <bratsche@gnome.org>
+
+       Bug 541964 – [Win32] Setting modal hint to current value might confuse the stack
+
+       * gdk/win32/gdkwindow-win32.c: Check if the value is the same as the
+       existing modal hint value before setting it.
+
 2008-07-07  Cody Russell  <bratsche@gnome.org>
 
        Bug 540994 – [Win32] Some windows don't appear at the top when created

diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c
index b6d3e6ef46315d4f609f325d3421c9faa8dcd76c..c9e8c0060a8c6eb4eb156f39ec76726f3a4bc68b 100644 (file)
--- a/gdk/win32/gdkwindow-win32.c
+++ b/gdk/win32/gdkwindow-win32.c
@@ -3548,6 +3548,9 @@ gdk_window_set_modal_hint (GdkWindow *window,
 
   private = (GdkWindowObject*) window;
 
+  if (modal == private->modal_hint)
+    return;
+
   private->modal_hint = modal;
 
 #if 0